[PATCH 16/18] remoteproc: st: Convert to platform remove callback returning void

[Patrice CHOTARD]

Hi Uwe

On 5/4/23 21:44, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  drivers/remoteproc/st_remoteproc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
> index 3f1b8963639f..e3ce01d98b4c 100644
> --- a/drivers/remoteproc/st_remoteproc.c
> +++ b/drivers/remoteproc/st_remoteproc.c
> @@ -448,7 +448,7 @@ static int st_rproc_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int st_rproc_remove(struct platform_device *pdev)
> +static void st_rproc_remove(struct platform_device *pdev)
>  {
>  	struct rproc *rproc = platform_get_drvdata(pdev);
>  	struct st_rproc *ddata = rproc->priv;
> @@ -462,13 +462,11 @@ static int st_rproc_remove(struct platform_device *pdev)
>  		mbox_free_channel(ddata->mbox_chan[i]);
>  
>  	rproc_free(rproc);
> -
> -	return 0;
>  }
>  
>  static struct platform_driver st_rproc_driver = {
>  	.probe = st_rproc_probe,
> -	.remove = st_rproc_remove,
> +	.remove_new = st_rproc_remove,
>  	.driver = {
>  		.name = "st-rproc",
>  		.of_match_table = of_match_ptr(st_rproc_match),

Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>

Thanks
Patrice