[PATCH net] net: phy: dp83867: add w/a for packet errors seen with short cables

Jakub Kicinski kuba at kernel.org
Mon May 8 19:00:35 PDT 2023


Thanks for the patch! Some nit picks below..

On Mon, 8 May 2023 12:30:19 +0530 Siddharth Vadapalli wrote:
> +	err = phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_DSP_FFE_CFG, 0X0E81);

Pleas wrap this line at 80 characters, there's no reason for it 
to be this long.

And 0x prefix should not be in upper case, here and in the new define
you're adding.
-- 
pw-bot: cr



More information about the linux-arm-kernel mailing list