[PATCH 53/53] drm/xlnx/zynqmp_dpsub: Convert to platform remove callback returning void

[Laurent Pinchart]

Hi Uwe,

Thank you for the patch.

On Sun, May 07, 2023 at 06:26:16PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index bab862484d42..9d64a8d98372 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -280,7 +280,7 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int zynqmp_dpsub_remove(struct platform_device *pdev)
> +static void zynqmp_dpsub_remove(struct platform_device *pdev)
>  {
>  	struct zynqmp_dpsub *dpsub = platform_get_drvdata(pdev);
>  
> @@ -298,8 +298,6 @@ static int zynqmp_dpsub_remove(struct platform_device *pdev)
>  
>  	if (!dpsub->drm)
>  		zynqmp_dpsub_release(dpsub);
> -
> -	return 0;
>  }
>  
>  static void zynqmp_dpsub_shutdown(struct platform_device *pdev)
> @@ -320,7 +318,7 @@ MODULE_DEVICE_TABLE(of, zynqmp_dpsub_of_match);
>  
>  static struct platform_driver zynqmp_dpsub_driver = {
>  	.probe			= zynqmp_dpsub_probe,
> -	.remove			= zynqmp_dpsub_remove,
> +	.remove_new		= zynqmp_dpsub_remove,
>  	.shutdown		= zynqmp_dpsub_shutdown,
>  	.driver			= {
>  		.name		= "zynqmp-dpsub",

-- 
Regards,

Laurent Pinchart