[RFC PATCH v7 7/8] netdev: expose DPLL pin handle for netdevice

Jiri Pirko jiri at resnulli.us
Fri May 5 03:32:12 PDT 2023


Thu, May 04, 2023 at 10:31:40PM CEST, kuba at kernel.org wrote:
>On Thu, 27 Apr 2023 17:20:08 -0700 Vadim Fedorenko wrote:
>> @@ -2411,6 +2412,10 @@ struct net_device {
>>  	struct rtnl_hw_stats64	*offload_xstats_l3;
>>  
>>  	struct devlink_port	*devlink_port;
>> +
>> +#if IS_ENABLED(CONFIG_DPLL)
>> +	struct dpll_pin		*dpll_pin;
>> +#endif
>
>kdoc is missing. I'm guessing that one pin covers all current user
>cases but we should clearly document on what this pin is, so that when
>we extend the code to support multiple pins (in/out, per lane, idk)
>we know which one this was.. ?

Oh, yeah. Will do.



More information about the linux-arm-kernel mailing list