[PATCH] net: ethernet: mtk_eth_soc: use be32 type to store be32 values
Simon Horman
horms at kernel.org
Fri Mar 31 23:43:44 PDT 2023
Perhaps there is a nicer way to handle this but the code
calls for converting an array of host byte order 32bit values
to big endian 32bit values: an ipv6 address to be pretty printed.
Use a sparse-friendly array of be32 to store these values.
Also make use of the cpu_to_be32_array helper rather
than open coding the conversion.
Flagged by sparse:
drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c:59:27: warning: incorrect type in assignment (different base types)
drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c:59:27: expected unsigned int
drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c:59:27: got restricted __be32 [usertype]
drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c:161:46: warning: cast to restricted __be16
No functional changes intended.
Compile tested only.
Signed-off-by: Simon Horman <horms at kernel.org>
---
drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c b/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c
index 53cf87e9acbb..1e0bb8cee7c4 100644
--- a/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c
+++ b/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c
@@ -47,16 +47,14 @@ static const char *mtk_foe_pkt_type_str(int type)
static void
mtk_print_addr(struct seq_file *m, u32 *addr, bool ipv6)
{
- u32 n_addr[4];
- int i;
+ __be32 n_addr[4];
if (!ipv6) {
seq_printf(m, "%pI4h", addr);
return;
}
- for (i = 0; i < ARRAY_SIZE(n_addr); i++)
- n_addr[i] = htonl(addr[i]);
+ cpu_to_be32_array(n_addr, addr, 4);
seq_printf(m, "%pI6", n_addr);
}
More information about the linux-arm-kernel
mailing list