[EXT] Re: [PATCH v3 2/2] net: stmmac: dwmac-imx: use platform specific reset for imx93 SoCs

[Shenwei Wang]

> -----Original Message-----
> From: Fabio Estevam <festevam at gmail.com>
> Sent: Friday, March 31, 2023 4:08 PM
> To: Shenwei Wang <shenwei.wang at nxp.com>
> Cc: David S. Miller <davem at davemloft.net>; Eric Dumazet
> <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni
> <pabeni at redhat.com>; Maxime Coquelin <mcoquelin.stm32 at gmail.com>;
> Shawn Guo <shawnguo at kernel.org>; Sascha Hauer <s.hauer at pengutronix.de>;
> Giuseppe Cavallaro <peppe.cavallaro at st.com>; Alexandre Torgue
> <alexandre.torgue at foss.st.com>; Jose Abreu <joabreu at synopsys.com>;
> Pengutronix Kernel Team <kernel at pengutronix.de>; dl-linux-imx <linux-
> imx at nxp.com>; Wong Vee Khee <veekhee at apple.com>; Tan Tee Min
> <tee.min.tan at linux.intel.com>; Revanth Kumar Uppala <ruppala at nvidia.com>;
> Jon Hunter <jonathanh at nvidia.com>; Andrey Konovalov
> <andrey.konovalov at linaro.org>; netdev at vger.kernel.org; linux-stm32 at st-md-
> mailman.stormreply.com; linux-arm-kernel at lists.infradead.org;
> imx at lists.linux.dev
> Subject: [EXT] Re: [PATCH v3 2/2] net: stmmac: dwmac-imx: use platform
> specific reset for imx93 SoCs
> 
> Caution: EXT Email
> 
> Hi Shenwei,
> 
> On Fri, Mar 31, 2023 at 5:58 PM Shenwei Wang <shenwei.wang at nxp.com>
> wrote:
> >
> > The patch addresses an issue with the reset logic on the i.MX93 SoC,
> > which requires configuration of the correct interface speed under RMII
> > mode to complete the reset. The patch implements a fix_soc_reset
> > function and uses it specifically for the i.MX93 SoCs.
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang at nxp.com>
> > ---
> >  .../net/ethernet/stmicro/stmmac/dwmac-imx.c   | 29 ++++++++++++++++++-
> >  1 file changed, 28 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> > b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> > index ac8580f501e2..3dfd13840535 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
> > @@ -19,9 +19,9 @@
> >  #include <linux/pm_wakeirq.h>
> >  #include <linux/regmap.h>
> >  #include <linux/slab.h>
> > -#include <linux/stmmac.h>
> >
> >  #include "stmmac_platform.h"
> > +#include "common.h"
> 
> These changes in the header seem to be unrelated.
> 

You are right. Will fixed.

Thanks,
Shenwei

> Apart from that:
> 
> Reviewed-by: Fabio Estevam <festevam at gmail.com>