[PATCH V3 2/6] dt-bindings: Add DS2482/DS2484 as trivial device

Stefan Wahren stefan.wahren at i2se.com
Fri Mar 31 11:25:02 PDT 2023


Hi Rob,

Am 31.03.23 um 17:49 schrieb Rob Herring:
> On Fri, Mar 31, 2023 at 4:58 AM Stefan Wahren
> <stefan.wahren at chargebyte.com> wrote:
>>
>> Both chips are I2C to 1-wire bridges.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren at chargebyte.com>
>> Cc: Steffen Trumtrar <s.trumtrar at pengutronix.de>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>> ---
>>   Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index 6f482a254a1d..9b7b24989359 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -183,6 +183,10 @@ properties:
>>             - maxim,ds1803-050
>>               # 100 kOhm digital potentiometer with I2C interface
>>             - maxim,ds1803-100
>> +            # I2C to 1-wire bridge
>> +          - maxim,ds2482
>> +            # I2C to 1-wire bridge
>> +          - maxim,ds2484
> 
> A 1-wire device isn't really trivial because it can have child nodes.
> You're probably not the first here, but don't add more.
> 
> You could do a "trivial 1-wire devices" schema similar to trivial RTC
> device schema.

okay. After thinking more about this, it isn't a trivial device at all. 
I will make a dedicated schema for this.

Best regards

> 
> Rob



More information about the linux-arm-kernel mailing list