[PATCH 4/6] clk: imx: fracn-gppll: support integer pll
kernel test robot
lkp at intel.com
Fri Mar 31 01:39:39 PDT 2023
Hi Peng,
I love your patch! Perhaps something to improve:
[auto build test WARNING on abelvesa/clk/imx]
[also build test WARNING on linus/master v6.3-rc4 next-20230331]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Peng-Fan-OSS/clk-imx-fracn-gppll-fix-the-rate-table/20230331-144314
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelvesa/linux.git clk/imx
patch link: https://lore.kernel.org/r/20230331064629.2475338-5-peng.fan%40oss.nxp.com
patch subject: [PATCH 4/6] clk: imx: fracn-gppll: support integer pll
config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20230331/202303311642.0nlzpIER-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/b80cff81a332a2005b90c5c1fbab96e732c03494
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Peng-Fan-OSS/clk-imx-fracn-gppll-fix-the-rate-table/20230331-144314
git checkout b80cff81a332a2005b90c5c1fbab96e732c03494
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/clk/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp at intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303311642.0nlzpIER-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/clk/imx/clk-fracn-gppll.c:340:16: warning: no previous prototype for '_imx_clk_fracn_gppll' [-Wmissing-prototypes]
340 | struct clk_hw *_imx_clk_fracn_gppll(const char *name, const char *parent_name, void __iomem *base,
| ^~~~~~~~~~~~~~~~~~~~
vim +/_imx_clk_fracn_gppll +340 drivers/clk/imx/clk-fracn-gppll.c
339
> 340 struct clk_hw *_imx_clk_fracn_gppll(const char *name, const char *parent_name, void __iomem *base,
341 const struct imx_fracn_gppll_clk *pll_clk, u32 pll_flags)
342 {
343 struct clk_fracn_gppll *pll;
344 struct clk_hw *hw;
345 struct clk_init_data init;
346 int ret;
347
348 pll = kzalloc(sizeof(*pll), GFP_KERNEL);
349 if (!pll)
350 return ERR_PTR(-ENOMEM);
351
352 init.name = name;
353 init.flags = pll_clk->flags;
354 init.parent_names = &parent_name;
355 init.num_parents = 1;
356 init.ops = &clk_fracn_gppll_ops;
357
358 pll->base = base;
359 pll->hw.init = &init;
360 pll->rate_table = pll_clk->rate_table;
361 pll->rate_count = pll_clk->rate_count;
362 pll->flags = pll_flags;
363
364 hw = &pll->hw;
365
366 ret = clk_hw_register(NULL, hw);
367 if (ret) {
368 pr_err("%s: failed to register pll %s %d\n", __func__, name, ret);
369 kfree(pll);
370 return ERR_PTR(ret);
371 }
372
373 return hw;
374 }
375
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
More information about the linux-arm-kernel
mailing list