[PATCH v7 12/12] drm: sun4: dsi: Convert to bridge driver

Maxime Ripard maxime at cerno.tech
Wed Mar 29 07:59:39 PDT 2023


Hi,

The patch prefix should be drm/sun4i:

On Wed, Mar 29, 2023 at 06:49:29PM +0530, Jagan Teki wrote:
> Convert the encoder to bridge driver in order to standardize on a
> single API by supporting all varients of downstream bridge devices.

Which variant, and why do we need to convert to a bridge to support all of them?

> The drm_encoder can't be removed as it's exposed to userspace, so it
> then becomes a dumb encoder, without any operation implemented.
> 
> Tested on DSI Panel, DSI Bridge, I2C-Configured DSI Bridge.
> 
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>

[...]

> +static const struct component_ops sun6i_dsi_ops;
> +
>  static int sun6i_dsi_attach(struct mipi_dsi_host *host,
>  			    struct mipi_dsi_device *device)
>  {
>  	struct sun6i_dsi *dsi = host_to_sun6i_dsi(host);
> -	struct drm_panel *panel = of_drm_find_panel(device->dev.of_node);

That one looks unrelated. Why do you need that change?

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230329/a84e5f85/attachment.sig>


More information about the linux-arm-kernel mailing list