[PATCH 071/117] media: s5p_mfc: Convert to platform remove callback returning void

[Andrzej Hajda]

On 26.03.2023 16:31, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Andrzej Hajda <andrzej.hajda at intel.com>

Regards
Andrzej

> ---
>   drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
> index 9d2cce124a34..e30e54935d79 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
> @@ -1431,7 +1431,7 @@ static int s5p_mfc_probe(struct platform_device *pdev)
>   }
>   
>   /* Remove the driver */
> -static int s5p_mfc_remove(struct platform_device *pdev)
> +static void s5p_mfc_remove(struct platform_device *pdev)
>   {
>   	struct s5p_mfc_dev *dev = platform_get_drvdata(pdev);
>   	struct s5p_mfc_ctx *ctx;
> @@ -1463,7 +1463,6 @@ static int s5p_mfc_remove(struct platform_device *pdev)
>   	s5p_mfc_unconfigure_dma_memory(dev);
>   
>   	s5p_mfc_final_pm(dev);
> -	return 0;
>   }
>   
>   #ifdef CONFIG_PM_SLEEP
> @@ -1690,7 +1689,7 @@ MODULE_DEVICE_TABLE(of, exynos_mfc_match);
>   
>   static struct platform_driver s5p_mfc_driver = {
>   	.probe		= s5p_mfc_probe,
> -	.remove		= s5p_mfc_remove,
> +	.remove_new	= s5p_mfc_remove,
>   	.driver	= {
>   		.name	= S5P_MFC_NAME,
>   		.pm	= &s5p_mfc_pm_ops,