[PATCH v4 3/8] mtd: spi-nor: Reorder the preparation vs locking steps

Miquel Raynal miquel.raynal at bootlin.com
Fri Mar 24 08:28:02 PDT 2023


Hi Tudor,

tudor.ambarus at linaro.org wrote on Fri, 17 Mar 2023 03:51:37 +0000:

> On 3/17/23 03:39, Tudor Ambarus wrote:
> > 
> > 
> > On 2/1/23 11:35, Miquel Raynal wrote:  
> >> The ->prepare()/->unprepare() hooks are now legacy, we no longer accept
> >> new drivers supporting them. The only remaining controllers using them
> >> acquires a per-chip mutex, which should not interfere with the rest of
> >> the operation done in the core. As a result, we should be safe to
> >> reorganize these helpers to first perform the preparation, before
> >> acquiring the core locks. This is necessary in order to be able to
> >> improve the locking mechanism in the core (coming next). No side effects
> >> are expected.
> >>
> >> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>  
> > 
> > Reviewed-by: Tudor Ambarus <tudor.ambarus at linaro.org>  
> 
> No, I take back my R-b. The reorder is fine, but you missed to update
> otp.c and swp.c, see below.

/me guilty

Not sure how that slipped in. Anyhow, I'll go through the missing files
ofc.

Thanks,
Miquèl



More information about the linux-arm-kernel mailing list