[PATCH 08/15] PCI: iproc: Convert to platform remove callback returning void

Florian Fainelli f.fainelli at gmail.com
Tue Mar 21 14:37:49 PDT 2023


On 3/21/23 12:32, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks.
> 
> The iproc driver always returns 0, it's just a bit hidden. So make
> iproc_pcie_remove() return void instead of always zero and convert the
> platform driver to the alternative remove callback that returns void and
> eventually replaces the int returning callback.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Acked-by: Florian Fainelli <f.fainelli at gmail.com>
-- 
Florian




More information about the linux-arm-kernel mailing list