[net-next PATCH v5 04/15] leds: Provide stubs for when CLASS_LED is disabled
Andrew Lunn
andrew at lunn.ch
Tue Mar 21 09:02:42 PDT 2023
> BTW yes I repro the problem.
>
> Checked the makefile and led-core.c is compiled with NEW_LEDS and
> led-class is compiled with LEDS_CLASS.
>
> led_init_default_state_get is in led-core.c and this is the problem with
> using LEDS_CLASS instead of NEW_LEDS...
>
> But actually why we are putting led_init_default_state_get behind a
> config? IMHO we should compile it anyway.
It is pointless if you don't have any LED support. To make it always
compiled, you would probably need to move it into leds.h. And then you
bloat every user with some code which is not hot path.
Andrew
More information about the linux-arm-kernel
mailing list