[PATCH v4 09/12] ARM: vfp: Use undef hook for handling VFP exceptions

Ard Biesheuvel ardb at kernel.org
Tue Mar 21 08:41:20 PDT 2023


On Tue, 21 Mar 2023 at 15:59, Linus Walleij <linus.walleij at linaro.org> wrote:
>
> On Mon, Mar 20, 2023 at 2:19 PM Ard Biesheuvel <ardb at kernel.org> wrote:
>
> > Now that the VFP support code has been reimplemented as a C function
> > that takes a struct pt_regs pointer and an opcode, we can use the
> > existing undef_hook framework to deal with undef exceptions triggered by
> > VFP instructions instead of having special handling in assembler.
> >
> > Signed-off-by: Ard Biesheuvel <ardb at kernel.org>
>
> Provided we can test that this does the right thing it looks really neat:
> Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
>

Thanks.

I have tested this on BB white (Cortex-A8) and on RPi1 (1176), using
several instances of testfloat running concurrently, and things work
as expected in all cases. (The BB white is my VPN gateway so it uses
kernel mode NEON as well).

More test coverage is always welcome, of course ..



More information about the linux-arm-kernel mailing list