[PATCH v4 10/12] ARM: entry: Disregard Thumb undef exception in coproc dispatch

Linus Walleij linus.walleij at linaro.org
Tue Mar 21 08:05:32 PDT 2023


On Mon, Mar 20, 2023 at 2:19 PM Ard Biesheuvel <ardb at kernel.org> wrote:

> Now that the only remaining coprocessor instructions being handled via
> the dispatch in entry-armv.S are ones that only exist in a ARM (A32)
> encoding, we can simplify the handling of Thumb undef exceptions, and
> send them straight to the undefined instruction handlers in C code.
>
> Signed-off-by: Ard Biesheuvel <ardb at kernel.org>

I gave up trying to follow the code because the diff gets really convoluted.

But the mere relief of getting rid of things like this terse thing:

> -       .pushsection __ex_table,"a"
> -       .long   1b, 4b
> -#if CONFIG_ARM_THUMB && __LINUX_ARM_ARCH__ >= 6 && CONFIG_CPU_V7
> -       .long   2b, 4b
> -       .long   3b, 4b
> -#endif

Make it worth it, so as long as it works I'm game.
Acked-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list