[EXT] [PATCH 08/11] usb: phy: mxs: Convert to platform remove callback returning void

[Frank Li]

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Sent: Sunday, March 19, 2023 4:24 AM
> To: Greg Kroah-Hartman <gregkh at linuxfoundation.org>; Shawn Guo
> <shawnguo at kernel.org>; Sascha Hauer <s.hauer at pengutronix.de>; Frank Li
> <frank.li at nxp.com>
> Cc: Fabio Estevam <festevam at gmail.com>; dl-linux-imx <linux-
> imx at nxp.com>; linux-usb at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; kernel at pengutronix.de
> Subject: [EXT] [PATCH 08/11] usb: phy: mxs: Convert to platform remove
> callback returning void
> 
> Caution: EXT Email
> 
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---

Reviewed-by: Frank Li <Frank.li at nxp.com>
 

>  drivers/usb/phy/phy-mxs-usb.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-
> usb.c
> index d2836ef5d15c..b21eecacc3b7 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -801,13 +801,11 @@ static int mxs_phy_probe(struct platform_device
> *pdev)
>         return usb_add_phy_dev(&mxs_phy->phy);
>  }
> 
> -static int mxs_phy_remove(struct platform_device *pdev)
> +static void mxs_phy_remove(struct platform_device *pdev)
>  {
>         struct mxs_phy *mxs_phy = platform_get_drvdata(pdev);
> 
>         usb_remove_phy(&mxs_phy->phy);
> -
> -       return 0;
>  }
> 
>  #ifdef CONFIG_PM_SLEEP
> @@ -853,7 +851,7 @@ static SIMPLE_DEV_PM_OPS(mxs_phy_pm,
> mxs_phy_system_suspend,
> 
>  static struct platform_driver mxs_phy_driver = {
>         .probe = mxs_phy_probe,
> -       .remove = mxs_phy_remove,
> +       .remove_new = mxs_phy_remove,
>         .driver = {
>                 .name = DRIVER_NAME,
>                 .of_match_table = mxs_phy_dt_ids,
> --
> 2.39.2