[PATCH 14/24] kbuild, firmware: imx: remove MODULE_LICENSE in non-modules

Nick Alcock nick.alcock at oracle.com
Mon Mar 20 03:36:15 PDT 2023


On 14 Mar 2023, Shawn Guo verbalised:

> On Fri, Feb 17, 2023 at 02:10:49PM +0000, Nick Alcock wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>> 
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>> 
>> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
>> Suggested-by: Luis Chamberlain <mcgrof at kernel.org>
>
> Should I apply it as a fix for 6.3-rc with Cc stable tag, or can it be
> a material for -next?

This is currently built against -next, but Luis has indicated an intent
to pull the lot in via -rc3 (hence my scrambling to get the series
polished up for him, tags attached etc now). So, er... yes? :)

-- 
NULL && (void)



More information about the linux-arm-kernel mailing list