[RFC 2/2] media: rkvdec: Add VP8 encoder

Daniel Almeida daniel.almeida at collabora.com
Sat Mar 18 16:23:10 PDT 2023


Hi Andrzej, one thing I noticed while looking at this:

> +struct hantro_vp8_entropy {
> +	/* TODO: int32_t? */
> +	int32_t coeff_prob[4][8][3][11];
> +	int32_t coeff_prob_old[4][8][3][11];
> +	int32_t mv_prob[2][19];
> +	int32_t mv_prob_old[2][19];
> +	int32_t y_mode_prob[4];
> +	int32_t uv_mode_prob[3];
> +};
> 


In VP9, probabilities are coded in the 0..255 range, so if you want to
save space here, you can go with uint8_t.

-- Daniel



More information about the linux-arm-kernel mailing list