[PATCH 033/173] ASoC: atmel: tse850-pcm5142: Convert to platform remove callback returning void

[Claudiu.Beznea at microchip.com]

On 15.03.2023 17:05, Uwe Kleine-König wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea at microchip.com>


> ---
>  sound/soc/atmel/tse850-pcm5142.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/atmel/tse850-pcm5142.c b/sound/soc/atmel/tse850-pcm5142.c
> index ef537de7719c..efead272d92b 100644
> --- a/sound/soc/atmel/tse850-pcm5142.c
> +++ b/sound/soc/atmel/tse850-pcm5142.c
> @@ -412,15 +412,13 @@ static int tse850_probe(struct platform_device *pdev)
>         return ret;
>  }
> 
> -static int tse850_remove(struct platform_device *pdev)
> +static void tse850_remove(struct platform_device *pdev)
>  {
>         struct snd_soc_card *card = platform_get_drvdata(pdev);
>         struct tse850_priv *tse850 = snd_soc_card_get_drvdata(card);
> 
>         snd_soc_unregister_card(card);
>         regulator_disable(tse850->ana);
> -
> -       return 0;
>  }
> 
>  static const struct of_device_id tse850_dt_ids[] = {
> @@ -435,7 +433,7 @@ static struct platform_driver tse850_driver = {
>                 .of_match_table = of_match_ptr(tse850_dt_ids),
>         },
>         .probe = tse850_probe,
> -       .remove = tse850_remove,
> +       .remove_new = tse850_remove,
>  };
> 
>  module_platform_driver(tse850_driver);
> --
> 2.39.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel