[PATCH 031/173] ASoC: atmel: sam9g20_wm8731: Convert to platform remove callback returning void

[Claudiu.Beznea at microchip.com]

On 15.03.2023 17:05, Uwe Kleine-König wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea at microchip.com>


> ---
>  sound/soc/atmel/sam9g20_wm8731.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 785b9d01d8af..baf38964b491 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -186,14 +186,12 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev)
>         return ret;
>  }
> 
> -static int at91sam9g20ek_audio_remove(struct platform_device *pdev)
> +static void at91sam9g20ek_audio_remove(struct platform_device *pdev)
>  {
>         struct snd_soc_card *card = platform_get_drvdata(pdev);
> 
>         snd_soc_unregister_card(card);
>         atmel_ssc_put_audio(0);
> -
> -       return 0;
>  }
> 
>  #ifdef CONFIG_OF
> @@ -210,7 +208,7 @@ static struct platform_driver at91sam9g20ek_audio_driver = {
>                 .of_match_table = of_match_ptr(at91sam9g20ek_wm8731_dt_ids),
>         },
>         .probe  = at91sam9g20ek_audio_probe,
> -       .remove = at91sam9g20ek_audio_remove,
> +       .remove_new = at91sam9g20ek_audio_remove,
>  };
> 
>  module_platform_driver(at91sam9g20ek_audio_driver);
> --
> 2.39.2
>