[PATCH 028/173] ASoC: atmel: mchp-spdifrx: Convert to platform remove callback returning void

[Claudiu.Beznea at microchip.com]

On 15.03.2023 17:05, Uwe Kleine-König wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea at microchip.com>


> ---
>  sound/soc/atmel/mchp-spdifrx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/atmel/mchp-spdifrx.c b/sound/soc/atmel/mchp-spdifrx.c
> index eb0c0ef4541e..ff6aba143aee 100644
> --- a/sound/soc/atmel/mchp-spdifrx.c
> +++ b/sound/soc/atmel/mchp-spdifrx.c
> @@ -1183,20 +1183,18 @@ static int mchp_spdifrx_probe(struct platform_device *pdev)
>         return err;
>  }
> 
> -static int mchp_spdifrx_remove(struct platform_device *pdev)
> +static void mchp_spdifrx_remove(struct platform_device *pdev)
>  {
>         struct mchp_spdifrx_dev *dev = platform_get_drvdata(pdev);
> 
>         pm_runtime_disable(dev->dev);
>         if (!pm_runtime_status_suspended(dev->dev))
>                 mchp_spdifrx_runtime_suspend(dev->dev);
> -
> -       return 0;
>  }
> 
>  static struct platform_driver mchp_spdifrx_driver = {
>         .probe  = mchp_spdifrx_probe,
> -       .remove = mchp_spdifrx_remove,
> +       .remove_new = mchp_spdifrx_remove,
>         .driver = {
>                 .name   = "mchp_spdifrx",
>                 .of_match_table = of_match_ptr(mchp_spdifrx_dt_ids),
> --
> 2.39.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel