[PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void

Nicolas Ferre nicolas.ferre at microchip.com
Wed Mar 15 08:49:37 PDT 2023


(with reduced sending list)

On 15/03/2023 at 16:04, Uwe Kleine-König wrote:
> Hello,
> 
> this series adapts the platform drivers below sound/ to use the .remove_new()
> callback. Compared to the traditional .remove() callback .remove_new() returns
> no value. This is a good thing because the driver core doesn't (and cannot)
> cope for errors during remove. The only effect of a non-zero return value in
> .remove() is that the driver core emits a warning. The device is removed anyhow
> and an early return from .remove() usually yields a resource leak.
> 
> By changing the remove callback to return void driver authors cannot
> reasonably assume any more that there is some kind of cleanup later.
> 
> The first two patches simplify a driver each to return zero unconditionally,
> and then all drivers are trivially converted to .remove_new().
> 
> There are nearly no interdependencies in this patch set---only 1 <- 11 and
> 2 <- 16. So even if some individual problems are found (I don't expect that),
> the other patches can (and from my POV should) still be applied.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (173):

[..]
>    ALSA: atmel: ac97: Convert to platform remove callback returning void
[..]
>    ASoC: atmel: atmel-i2s: Convert to platform remove callback returning
>      void
>    ASoC: atmel: atmel_wm8904: Convert to platform remove callback
>      returning void
>    ASoC: atmel: mchp-i2s-mcc: Convert to platform remove callback
>      returning void
>    ASoC: atmel: mchp-pdmc: Convert to platform remove callback returning
>      void
>    ASoC: atmel: mchp-spdifrx: Convert to platform remove callback
>      returning void
>    ASoC: atmel: mchp-spdiftx: Convert to platform remove callback
>      returning void
>    ASoC: atmel: mikroe-proto: Convert to platform remove callback
>      returning void
>    ASoC: atmel: sam9g20_wm8731: Convert to platform remove callback
>      returning void
>    ASoC: atmel: sam9x5_wm8731: Convert to platform remove callback
>      returning void
>    ASoC: atmel: tse850-pcm5142: Convert to platform remove callback
>      returning void

For all "atmel" related changes:
Acked-by: Nicolas Ferre <nicolas.ferre at microchip.com>

Thanks Uwe!

[..]

>   171 files changed, 345 insertions(+), 654 deletions(-)
> 
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> --
> 2.39.2
> 

Regards,
-- 
Nicolas Ferre




More information about the linux-arm-kernel mailing list