[PATCH V8 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver

[Devi Priya]

On 3/8/2023 6:54 PM, Andy Shevchenko wrote:
> On Wed, Mar 8, 2023 at 11:52 AM Devi Priya <quic_devipriy at quicinc.com> wrote:
>> On 3/7/2023 5:28 AM, andy.shevchenko at gmail.com wrote:
> 
> ...
> 
>>>> +    depends on OF
>>>
>>> No compile test on non-OF configurations?
> 
>> As per the generic convention followed in other
>> SoCs, we do not have compile test on non-OF configurations
> 
> Why not? So, you have to explain the deliberate narrowing of the test coverageOn adding 'depends on OF || COMPILE_TEST', the driver compiles
for non-OF configuration as well.
Will update this in the next spin!
> 
>>>> +    depends on ARM64 || COMPILE_TEST
> 
> ...
> 
>>>> +#define FUNCTION(fname)                                     \
>>>
>>> PINCTRL_PINFUNCTION() ?
>> I see that there are quite a bunch of files that has to
>> be modified for using the generic data type and
>> macro for the pin function definition
>> We shall post a separate series to accommodate the changes
> 
> Sure, that's fine. Please do!
Sure, thanks
> 
>>>> +    [msm_mux_##fname] = {                           \
>>>> +            .name = #fname,                         \
>>>> +            .groups = fname##_groups,               \
>>>> +            .ngroups = ARRAY_SIZE(fname##_groups),  \
>>>> +    }
> 
> ...
> 
>>>> +#define PINGROUP(id, f1, f2, f3, f4, f5, f6, f7, f8, f9)    \
>>>> +    {                                               \
>>>> +            .name = "gpio" #id,                     \
>>>> +            .pins = gpio##id##_pins,                \
>>>> +            .npins = (unsigned int)ARRAY_SIZE(gpio##id##_pins),     \
>>>
>>> Can you embed struct pingroup?
>> Will take care of this in a separate series
> 
> Ditto. Thanks!
Sure, thanks
> 
>>>> +    }
> 
> ...
> 
>>>> +};
>>>
>>> No MODULE_DEVICE_TABLE()?
>> The MODULE_DEVICE_TABLE(of, ipq9574_pinctrl_of_match) entry has
>> been added at the end of the file
> 
> So, you know what to do then to address my comment :-)
Yep, got it!
> 

Best Regards,
Devi Priya