[PATCH 07/27] iommu/sun50i: remove MODULE_LICENSE in non-modules

Jernej Škrabec jernej.skrabec at gmail.com
Tue Mar 14 13:15:16 PDT 2023


Dne petek, 24. februar 2023 ob 16:07:51 CET je Nick Alcock napisal(a):
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof at kernel.org>
> Cc: Luis Chamberlain <mcgrof at kernel.org>
> Cc: linux-modules at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi at fujitsu.com>
> Cc: Joerg Roedel <joro at 8bytes.org>
> Cc: Will Deacon <will at kernel.org>
> Cc: Chen-Yu Tsai <wens at csie.org>
> Cc: Jernej Skrabec <jernej.skrabec at gmail.com>
> Cc: Samuel Holland <samuel at sholland.org>
> Cc: Philipp Zabel <p.zabel at pengutronix.de>
> Cc: iommu at lists.linux.dev
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-sunxi at lists.linux.dev
> ---
>  drivers/iommu/sun50i-iommu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iommu/sun50i-iommu.c b/drivers/iommu/sun50i-iommu.c
> index 5b585eace3d4..63ac9d15b859 100644
> --- a/drivers/iommu/sun50i-iommu.c
> +++ b/drivers/iommu/sun50i-iommu.c
> @@ -1077,4 +1077,3 @@ builtin_platform_driver_probe(sun50i_iommu_driver,
> sun50i_iommu_probe); MODULE_DESCRIPTION("Allwinner H6 IOMMU driver");
>  MODULE_AUTHOR("Maxime Ripard <maxime at cerno.tech>");
>  MODULE_AUTHOR("zhuxianbin <zhuxianbin at allwinnertech.com>");
> -MODULE_LICENSE("Dual BSD/GPL");

Acked-by: Jernej Skrabec <jernej.skrabec at gmail.com>

Best regards,
Jernej






More information about the linux-arm-kernel mailing list