[PATCH v3] iio: adc: at91-sama5d2_adc: remove dead code in `at91_adc_probe`

Cheng Ziqiu chengziqiu at hust.edu.cn
Tue Mar 14 00:01:30 PDT 2023


>From the comment of platform_get_irq, it only returns non-zero IRQ
number and negative error number, other than zero.

Fix this by removing the if condition.

Signed-off-by: Cheng Ziqiu <chengziqiu at hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91 at hust.edu.cn>
---
v2->v3: Change subject to make it regular.
v1->v2: Change commit message from SoB to Reviewed-by.
 drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index 50d02e5fc6fc..168399092590 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
 	st->dma_st.phys_addr = res->start;
 
 	st->irq = platform_get_irq(pdev, 0);
-	if (st->irq <= 0) {
-		if (!st->irq)
-			st->irq = -ENXIO;
-
+	if (st->irq < 0)
 		return st->irq;
-	}
 
 	st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
 	if (IS_ERR(st->per_clk))
-- 
2.34.1




More information about the linux-arm-kernel mailing list