[PATCH 05/28] media: rc: gpio-ir-tx: drop of_match_ptr for ID table

Sean Young sean at mess.org
Mon Mar 13 07:45:56 PDT 2023


On Sun, Mar 12, 2023 at 02:12:55PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).  This
> also fixes !CONFIG_OF error:
> 
>   drivers/media/rc/gpio-ir-tx.c:24:34: error: ‘gpio_ir_tx_of_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>

Reviewed-by: Sean Young <sean at mess.org>

Thanks
Sean

> ---
>  drivers/media/rc/gpio-ir-tx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/gpio-ir-tx.c b/drivers/media/rc/gpio-ir-tx.c
> index 2b829c146db1..1a8fea357f14 100644
> --- a/drivers/media/rc/gpio-ir-tx.c
> +++ b/drivers/media/rc/gpio-ir-tx.c
> @@ -199,7 +199,7 @@ static struct platform_driver gpio_ir_tx_driver = {
>  	.probe	= gpio_ir_tx_probe,
>  	.driver = {
>  		.name	= DRIVER_NAME,
> -		.of_match_table = of_match_ptr(gpio_ir_tx_of_match),
> +		.of_match_table = gpio_ir_tx_of_match,
>  	},
>  };
>  module_platform_driver(gpio_ir_tx_driver);
> -- 
> 2.34.1



More information about the linux-arm-kernel mailing list