[PATCH 0/5] clocksource: Convert to platform remove callback returning void

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Mar 13 00:54:25 PDT 2023


Hello,

this patch series adapts the platform drivers below drivers/clk
to use the .remove_new() callback. Compared to the traditional .remove()
callback .remove_new() returns no value. This is a good thing because
the driver core doesn't (and cannot) cope for errors during remove. The
only effect of a non-zero return value in .remove() is that the driver
core emits a warning. The device is removed anyhow and an early return
from .remove() usually yields a resource leak.

Most clocksource drivers are not supposed to be removed. Two drivers are
adapted here to actually prevent removal. One driver is fixed not to
return an error code in .remove() and then the two remaining drivers
with a remove callback are trivially converted to .remove_new().

Best regards
Uwe

Uwe Kleine-König (5):
  clocksource: sh_mtu2: Mark driver as non-removable
  clocksource: timer-stm32-lp: Mark driver as non-removable
  clocksource: timer-ti-dm: Improve error message in .remove
  clocksource: timer-tegra186: Convert to platform remove callback
    returning void
  clocksource: timer-ti-dm: Convert to platform remove callback
    returning void

 drivers/clocksource/sh_mtu2.c        | 7 +------
 drivers/clocksource/timer-stm32-lp.c | 7 +------
 drivers/clocksource/timer-tegra186.c | 6 ++----
 drivers/clocksource/timer-ti-dm.c    | 7 ++++---
 4 files changed, 8 insertions(+), 19 deletions(-)


base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
-- 
2.39.1




More information about the linux-arm-kernel mailing list