Aw: Re: Re: [PATCH net-next v12 08/18] net: ethernet: mtk_eth_soc: fix 1000Base-X and 2500Base-X modes

[Frank Wunderlich]

and i can confirm that disabling autoneg on userspace brings up link on the 2.5g rj45 sfp

root at bpi-r3:~# ip link set eth1 up
[   73.433869] mtk_soc_eth 15100000.ethernet eth1: configuring for inband/2500base-x link mode
root at bpi-r3:~# ip link show eth1
3: eth1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 1000
    link/ether 92:2f:d3:16:6f:94 brd ff:ff:ff:ff:ff:ff
root at bpi-r3:~# ethtool -s eth1 autoneg off
root at bpi-r3:~# [  147.190136] mtk_soc_eth 15100000.ethernet eth1: Link is Up - 2.5Gbps/Full - flow control off
[  147.198600] IPv6: ADDRCONF(NETDEV_CHANGE): eth1: link becomes ready
root at bpi-r3:~#

wonder which flags this changes compared to the original state...these i have to set in code when the sfp is recognized.

setting these flags in the phylink_parse_mode (or skipping set AN-flags) seem to break it completely

regards Frank