[PATCH 04/10] cpuidle, psci: Push RCU-idle into driver

Geert Uytterhoeven geert at linux-m68k.org
Fri Mar 10 00:47:20 PST 2023


Hi Cheng,

On Fri, Mar 3, 2023 at 10:35 AM Cheng-Jui Wang
<cheng-jui.wang at mediatek.com> wrote:
> From: Peter Zijlstra <peterz at infradead.org>
>
> commit e038f7b8028a1d1bc8ac82351c71ea538f19a879 upstream.
>
> Doing RCU-idle outside the driver, only to then temporarily enable it
> again, at least twice, before going idle is suboptimal.
>
> Notably once implicitly through the cpu_pm_*() calls and once
> explicitly doing ct_irq_*_irqon().
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz at infradead.org>
> Signed-off-by: Ingo Molnar <mingo at kernel.org>
> Tested-by: Kajetan Puchalski <kajetan.puchalski at arm.com>
> Tested-by: Tony Lindgren <tony at atomide.com>
> Tested-by: Ulf Hansson <ulf.hansson at linaro.org>
> Reviewed-by: Frederic Weisbecker <frederic at kernel.org>
> Reviewed-by: Guo Ren <guoren at kernel.org>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
> Link: https://lore.kernel.org/r/20230112195539.760296658@infradead.org
> Signed-off-by: Suren Baghdasaryan <surenb at google.com>
> Signed-off-by: Cheng-Jui Wang <cheng-jui.wang at mediatek.com>

Given this patch introduced a so far unresolved regression upstream,
I think it's premature to backport this to stable.

https://lore.kernel.org/all/ff338b9f-4ab0-741b-26ea-7b7351da156@linux-m68k.org

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-arm-kernel mailing list