[PATCH v1] drivers/gpio: remove redundant platform_set_drvdata()

Bartosz Golaszewski brgl at bgdev.pl
Wed Mar 8 02:26:14 PST 2023


On Mon, Mar 6, 2023 at 11:54 PM <andy.shevchenko at gmail.com> wrote:
>
> Mon, Mar 06, 2023 at 11:15:32PM +0800, Lizhe kirjoitti:
> > remove redundant platform_set_drvdata(),
> > Because there is no place to use the platform_get_drvdata
>
> The commit message has to be improved:
> - English grammar and punctuation
> - style of func()
> - clearer wording on what it all means
>
> Note, to get driver data the dev_get_drvdata() can be used. Do you aware about
> this? And hHow did you check these drivers?
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

I would also add to that: you need to use your full first and family
name in SoB because I assume you don't just go by "Lizhe".

Bartosz



More information about the linux-arm-kernel mailing list