[PATCH 7/8] ARM: dts: imx6ull: Add chargebyte Tarragon support

Stefan Wahren stefan.wahren at i2se.com
Tue Mar 7 09:25:23 PST 2023


Hi Krzysztof,

Am 07.03.23 um 09:30 schrieb Krzysztof Kozlowski:
> On 06/03/2023 18:22, Stefan Wahren wrote:
>> From: Stefan Wahren <stefan.wahren at chargebyte.com>
>>
>> This adds the support for chargebyte Tarragon, which is an Electrical
>> Vehicle Supply Equipment (EVSE) for AC charging stations
>> (according to IEC 61851, ISO 15118).
>>
>> The Tarragon board is based on an i.MX6ULL SoC and is available in
>> 4 variants (Master, Slave, SlaveXT, Micro), which provide more or
>> less peripherals.
>>
>> Supported features:
>>    * 512 MB DDR RAM
>>    * eMMC
>>    * Debug UART
>>    * 100 Mbit Ethernet
>>    * USB 2.0 Host interface
>>    * Powerline communication (QCA700x)
>>    * 2x RS485
>>    * Digital in- and outputs (12 V)
>>    * One-Wire master for external temp sensors
>>    * 2x relay outputs
>>    * 2x motor interfaces
>>
>> Link: https://chargebyte.com/products/charging-station-communication/charge-control-c
>> Signed-off-by: Stefan Wahren <stefan.wahren at chargebyte.com>
>> Signed-off-by: Stefan Wahren <stefan.wahren at i2se.com>
>> ---
>>   arch/arm/boot/dts/Makefile                    |   4 +
>>   .../arm/boot/dts/imx6ull-tarragon-common.dtsi | 858 ++++++++++++++++++
>>   arch/arm/boot/dts/imx6ull-tarragon-master.dts |  82 ++
>>   arch/arm/boot/dts/imx6ull-tarragon-micro.dts  |  10 +
>>   arch/arm/boot/dts/imx6ull-tarragon-slave.dts  |  32 +
>>   .../arm/boot/dts/imx6ull-tarragon-slavext.dts |  64 ++
>>   6 files changed, 1050 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-common.dtsi
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-master.dts
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-micro.dts
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-slave.dts
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-slavext.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index efe4152e5846..aae52a6380bc 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -755,6 +755,10 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
>>   	imx6ull-phytec-segin-lc-rdk-nand.dtb \
>>   	imx6ull-phytec-tauri-emmc.dtb \
>>   	imx6ull-phytec-tauri-nand.dtb \
>> +	imx6ull-tarragon-master.dtb \
>> +	imx6ull-tarragon-micro.dtb \
>> +	imx6ull-tarragon-slave.dtb \
>> +	imx6ull-tarragon-slavext.dtb \
>>   	imx6ull-tqma6ull2-mba6ulx.dtb \
>>   	imx6ull-tqma6ull2l-mba6ulx.dtb \
>>   	imx6ulz-14x14-evk.dtb \
>> diff --git a/arch/arm/boot/dts/imx6ull-tarragon-common.dtsi b/arch/arm/boot/dts/imx6ull-tarragon-common.dtsi
>> new file mode 100644
>> index 000000000000..1099dd688e80
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6ull-tarragon-common.dtsi
>> @@ -0,0 +1,858 @@
>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>> +//
>> +// Copyright (C) 2023 chargebyte GmbH
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/input/input.h>
>> +#include <dt-bindings/leds/common.h>
>> +#include <dt-bindings/pwm/pwm.h>
>> +#include "imx6ull.dtsi"
>> +
>> +/ {
>> +	aliases {
>> +		mmc0 = &usdhc2; /* eMMC */
>> +	};
>> +
>> +	chosen {
>> +		stdout-path = &uart4;
>> +	};
>> +
>> +	memory at 80000000 {
>> +		device_type = "memory";
>> +		reg = <0x80000000 0x20000000>;
>> +	};
>> +
>> +	emmc_pwrseq: emmc-pwrseq {
>> +		compatible = "mmc-pwrseq-emmc";
>> +		pinctrl-0 = <&pinctrl_emmc_rst>;
>> +		pinctrl-names = "default";
>> +		reset-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>;
>> +	};
>> +
>> +	reg_dcdc_3v3: regulator-dcdc-3v3 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "dcdc-3v3";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
>> +
>> +	reg_1v8: regulator-1v8 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "ldo-1v8";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
>> +
>> +	leds {
>> +		compatible = "gpio-leds";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_status_leds>;
>> +
>> +		led1 {
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).

I ran make dtbs_check before sending this series. All of these issues in 
the included dtsi files makes it hard to spot DTS specific issues. This 
is the output of make dtbs_check:

   DTC_CHK arch/arm/boot/dts/imx6ull-tarragon-master.dtb
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
nand-controller at 1806000: #size-cells:0:0: 0 was expected
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/mtd/nand-controller.yaml
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
nand-controller at 1806000: #size-cells:0:0: 0 was expected
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/spba-bus at 2000000/spi at 200c000/ethernet at 0: failed to 
match any schema with compatible: ['qca,qca7000']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/spba-bus at 2000000/spi at 2014000/ethernet at 0: failed to 
match any schema with compatible: ['qca,qca7000']
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial at 2018000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial at 2020000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/spba-bus at 2000000/asrc at 2034000: failed to match any 
schema with compatible: ['fsl,imx6ul-asrc', 'fsl,imx53-asrc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/spba-bus at 2000000/asrc at 2034000: failed to match any 
schema with compatible: ['fsl,imx6ul-asrc', 'fsl,imx53-asrc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/tsc at 2040000: failed to match any schema with 
compatible: ['fsl,imx6ul-tsc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/anatop at 20c8000: failed to match any schema with 
compatible: ['fsl,imx6ul-anatop', 'fsl,imx6q-anatop', 'syscon', 
'simple-mfd']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/anatop at 20c8000: failed to match any schema with 
compatible: ['fsl,imx6ul-anatop', 'fsl,imx6q-anatop', 'syscon', 
'simple-mfd']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/usbphy at 20c9000: failed to match any schema with 
compatible: ['fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/usbphy at 20c9000: failed to match any schema with 
compatible: ['fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/usbphy at 20ca000: failed to match any schema with 
compatible: ['fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/usbphy at 20ca000: failed to match any schema with 
compatible: ['fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/snvs at 20cc000: failed to match any schema with 
compatible: ['fsl,sec-v4.0-mon', 'syscon', 'simple-mfd']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/snvs at 20cc000/snvs-rtc-lp: failed to match any schema 
with compatible: ['fsl,sec-v4.0-mon-rtc-lp']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/snvs at 20cc000/snvs-powerkey: failed to match any schema 
with compatible: ['fsl,sec-v4.0-pwrkey']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/pinctrl at 20e0000: failed to match any schema with 
compatible: ['fsl,imx6ul-iomuxc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/iomuxc-gpr at 20e4000: failed to match any schema with 
compatible: ['fsl,imx6ul-iomuxc-gpr', 'fsl,imx6q-iomuxc-gpr', 'syscon']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2000000/iomuxc-gpr at 20e4000: failed to match any schema with 
compatible: ['fsl,imx6ul-iomuxc-gpr', 'fsl,imx6q-iomuxc-gpr', 'syscon']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2100000/usb at 2184000: failed to match any schema with 
compatible: ['fsl,imx6ul-usb', 'fsl,imx27-usb']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2100000/usb at 2184000: failed to match any schema with 
compatible: ['fsl,imx6ul-usb', 'fsl,imx27-usb']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2100000/usb at 2184200: failed to match any schema with 
compatible: ['fsl,imx6ul-usb', 'fsl,imx27-usb']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2100000/usb at 2184200: failed to match any schema with 
compatible: ['fsl,imx6ul-usb', 'fsl,imx27-usb']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2100000/usbmisc at 2184800: failed to match any schema with 
compatible: ['fsl,imx6ul-usbmisc', 'fsl,imx6q-usbmisc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2100000/usbmisc at 2184800: failed to match any schema with 
compatible: ['fsl,imx6ul-usbmisc', 'fsl,imx6q-usbmisc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2100000/weim at 21b8000: failed to match any schema with 
compatible: ['fsl,imx6ul-weim', 'fsl,imx6q-weim']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2100000/weim at 21b8000: failed to match any schema with 
compatible: ['fsl,imx6ul-weim', 'fsl,imx6q-weim']
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial at 21f0000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial at 21f4000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial at 21fc000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus at 2200000/iomuxc-snvs at 2290000: failed to match any schema with 
compatible: ['fsl,imx6ull-iomuxc-snvs']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: /pwm-fan: failed to match 
any schema with compatible: ['pwm-fan']

Can you please point me, what is wrong or did you refer just to the 
deprecated "label" property which doesn't throw a warning in my case?

Did i missed a parameter?

Best regards




More information about the linux-arm-kernel mailing list