[PATCH v3 2/2] arm64: dts: mediatek: enable i2c0 for mt8365-evk board
AngeloGioacchino Del Regno
angelogioacchino.delregno at collabora.com
Tue Mar 7 01:46:52 PST 2023
Il 06/03/23 14:47, Alexandre Mergnat ha scritto:
> Enable the I2C0 bus provides communication with:
> - The integrated RT9466 Switching Battery Charger.
> - The integrated MT6691 LP4X buck for VDDQ.
> - The integrated MT6691 LP4X buck for VDD2.
> - The pin header, to plug external I2C devices.
>
> Signed-off-by: Alexandre Mergnat <amergnat at baylibre.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
> index 4683704ea235..b68aee8f229f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
> @@ -87,6 +87,15 @@ optee_reserved: optee at 43200000 {
> };
> };
>
> +&i2c0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_pins>;
> + clock-frequency = <100000>;
> + status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
Address and size cells are useless if there's no subnode of i2c0...
besides that, please keep the properties ordered by name.
clock-frequency
pinctrl-0
pinctrl-names
status
> +};
> +
> &pio {
> gpio_keys: gpio-keys-pins {
> pins {
> @@ -96,6 +105,16 @@ pins {
> };
> };
>
> + i2c0_pins: i2c0-pins {
> + pins {
> + pinmux = <MT8365_PIN_57_SDA0__FUNC_SDA0_0>,
> + <MT8365_PIN_58_SCL0__FUNC_SCL0_0>;
> + mediatek,pull-up-adv = <3>;
> + mediatek,drive-strength-adv = <00>;
bias-pull-up;
mediatek,d...
mediatek,p....
Also, "00" is the same as "0", being this not a string... so write it as 0.
Thanks,
Angelo
More information about the linux-arm-kernel
mailing list