[PATCH 0/9] ARM: dts: imx28: Clean up older DTS files

[Krzysztof Kozlowski]

On 06/03/2023 03:58, Shawn Guo wrote:
> On Fri, Feb 03, 2023 at 02:13:03PM +0100, Sascha Hauer wrote:
>> On Fri, Feb 03, 2023 at 10:44:49AM +0100, Sébastien Szymanski wrote:
>>> Hello,
>>>
>>> On 2/1/23 21:33, Stefan Wahren wrote:
>>>> Since the imx28 belongs to the early ARM platforms which has been
>>>> adapted to DT, a lot of these DTS files are not in the best shape.
>>>> So this series tries to address this by using label references
>>>> and SPDX tags.
>>>>
>>>> Theses patches doesn't include functional changes. The resulting
>>>> DTB files has been verified with dtdiff.
>>>>
>>>> Stefan Wahren (9):
>>>>    ARM: dts: imx28-apf28: Convert to use label references
>>>>    ARM: dts: imx28-m28/sps1: Convert to use label references
>>>>    ARM: dts: imx28-apx4devkit: Convert to use label references
>>>>    ARM: dts: imx28-cfa10036: Convert to use label references
>>>>    ARM: dts: imx28-duckbill: Convert to use label references
>>>>    ARM: dts: imx28-duckbill-2: Include base board
>>>>    ARM: dts: imx28-evk: Convert to use label references
>>>>    ARM: dts: imx28-ts4600: Convert to use label references
>>>>    ARM: dts: imx28-tx28: add SPDX-License-Identifier
>>>>
>>>>   arch/arm/boot/dts/imx28-apf28.dts             |  96 ++--
>>>>   arch/arm/boot/dts/imx28-apf28dev.dts          | 312 ++++++------
>>>>   arch/arm/boot/dts/imx28-apx4devkit.dts        | 380 +++++++-------
>>>>   arch/arm/boot/dts/imx28-cfa10036.dts          | 193 ++++----
>>>>   arch/arm/boot/dts/imx28-cfa10049.dts          | 454 +++++++++--------
>>>>   arch/arm/boot/dts/imx28-cfa10055.dts          | 224 +++++----
>>>>   arch/arm/boot/dts/imx28-cfa10056.dts          | 146 +++---
>>>>   arch/arm/boot/dts/imx28-cfa10057.dts          | 252 +++++-----
>>>>   arch/arm/boot/dts/imx28-cfa10058.dts          | 186 ++++---
>>>>   arch/arm/boot/dts/imx28-duckbill-2-485.dts    | 174 +------
>>>>   .../arm/boot/dts/imx28-duckbill-2-enocean.dts | 198 +-------
>>>>   arch/arm/boot/dts/imx28-duckbill-2-spi.dts    | 211 ++------
>>>>   arch/arm/boot/dts/imx28-duckbill-2.dts        | 256 +++++-----
>>>>   arch/arm/boot/dts/imx28-duckbill.dts          | 196 ++++----
>>>>   arch/arm/boot/dts/imx28-evk.dts               | 462 +++++++++---------
>>>>   arch/arm/boot/dts/imx28-m28.dtsi              |  44 +-
>>>>   arch/arm/boot/dts/imx28-m28cu3.dts            | 354 +++++++-------
>>>>   arch/arm/boot/dts/imx28-m28evk.dts            | 420 ++++++++--------
>>>>   arch/arm/boot/dts/imx28-sps1.dts              | 201 ++++----
>>>>   arch/arm/boot/dts/imx28-ts4600.dts            |  80 ++-
>>>>   arch/arm/boot/dts/imx28-tx28.dts              |  38 +-
>>>>   21 files changed, 2142 insertions(+), 2735 deletions(-)
>>>>
>>>
>>> FYI, such changes have been rejected years ago:
>>>
>>> https://lore.kernel.org/linux-arm-kernel/20140512141814.GE8330@dragon/
>>
>> I hope the attitude has changed here in the last years. Device trees
>> with label references are so much easier to read and to maintain.
> 
> Ok, I'm flexible on this.  Considering Krzysztof has been doing the same
> for other platforms, I guess arm-soc folks changed their thoughts.

I know only one platform - Tegra - as intentionally not using labels.
When I was converting old DTS to label-style, I found several issues -
both minor and more important - thus it's a clear win for me.

Best regards,
Krzysztof