[PATCH v2 0/2] watchdog: s3c2410_wdt: Simplify using dev_err_probe()
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Mon Mar 6 22:56:01 PST 2023
Hello,
changes since (implicit) v1, sent with Message-Id:
20230306090919.2206871-1-u.kleine-koenig at pengutronix.de:
- Rework patch #1 to keep s3c2410_get_wdt_drv_data() as a separate
function. The return value has to change however to make effective
use of dev_err_probe(). (I thought about using
return ERR_PTR(dev_err_probe(...));
but this looks too ugly and that's less effective because then
dev_err_probe cannot be compiled into a tail call.)
- Squash patches #2 and #3. This destroys the pretty bloatometer
statistic, in fact bloatometer diagnoses that the code gets bigger.
I'm a bit surprised but didn't try to understand it. I assume that's
because the additional parameter that dev_err_probe has to get over
dev_err is the culprit. Still given that the error code is now
included in the error message this is an IMHO nice patch.
Now that Gunter likes patch #1 better than the one from v1, I wonder
about his position about patch #2.
Best regards
Uwe
Uwe Kleine-König (2):
watchdog: s3c2410: Make s3c2410_get_wdt_drv_data() return an int
watchdog: s3c2410_wdt: Simplify using dev_err_probe()
drivers/watchdog/s3c2410_wdt.c | 47 +++++++++++++++-------------------
1 file changed, 20 insertions(+), 27 deletions(-)
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
prerequisite-patch-id: 775bdd863307268e1ef16250bf2f40862637b453
prerequisite-patch-id: 924ddfbe583e97e7c9a46c2460ecbc88c29ee319
--
2.39.1
More information about the linux-arm-kernel
mailing list