[PATCH 0/3] Ampere Computing ETMv4.x Support

Steve Clevenger scclevenger at os.amperecomputing.com
Mon Mar 6 17:24:15 PST 2023


Hi Suzuki,

I submitted the Ampere patches on a new thread to forego the delta. But,
here's a summary of the changes from Version 1. Please allow some nits
(title, etc.) to remain in place so I don't have to resubmit all the
patch files.

Thanks,
Steve

Version 2 changes:
Addressed Suzuki Poulose, Mike Leach, and James Clark V1 comments:

1. Moved early clear of TRCOSLAR.OSLK code from etm4_init_arch_data to
etm4_init_iomem_access. The early clear is now done for all
manufacturers, instead of based on drvdata mmio_external flag (set for
Ampere). The flag is deprecated.
2. Moved et4x_split_read64 implementation into etm4x_relaxed_read64, and
etm4x_split_write64 into etm4x_relaxed_write64. This cleared up code
changes in coresight-etm4x-core.c where ever these were used.
3. etm4x_relaxed_read64 and etm4x_relaxed_write64 are implemented as
static inline instead of macro definitions.
4. Removed struct etm4_drvdata mmio_external flag, and moved
no_quad_mmio flag to struct csdev_access. Then ensure pre-initialized
csdev_access fields get preserved.
5. Dropped /linux/drivers/amba/bus.c debug statement patch to provide
visibility to CoreSight PID/CID.

On 3/6/2023 2:54 AM, Suzuki K Poulose wrote:
> On 06/03/2023 05:54, Steve Clevenger wrote:
>> Ampere ETMv4.x support. Added Ampere ETM ID, and changes required by
>> the Ampere ETMv4.x hardware implementation.
>>
> 
> nit: Subject should be :
> 
> [PATCH <version> 0/X] <subsystem>: <component>: <Title>
> 
> in this case case:
> 
> <version> = NULL if version == 1
>           = version, otherwise
> Helps us to keep track of different versions of the postings.
> 
> <subsystem> == coresight
> 
> This helps the reviewers to "notice" or "ignore" a given series
> depending on their interest.
> 
> <component> == etm4x
> This further helps the reviewers to filter the mails within a subsystem.
> 
> [PATCH v2 0/3] coresight: etm4x: Support for Ampere computing
> 
> Also, please include a changelog from the previous version to indicate
> what has changed. e.g,
> 
> "Changes since v1:
>   - Modified xyz
>   - Dropped abc
>   - Addressed comments on ijk (<name of the requester>
> "
> 
> That helps the reviewers to get a picture of what they should be looking
> at and better spend their time.
> 
> Kind regards
> Suzuki
>> Steve Clevenger (3):
>>    Add known list of Ampere ETMv4 errata
>>    coresight etm4x: Early clear TRCOSLAR.OSLK prior to TRCIDR1 read
>>    coresight etm4x: Add 32-bit read/write option to split 64-bit words
>>
>>   Documentation/arm64/silicon-errata.rst        |  6 +-
>>   .../coresight/coresight-etm4x-core.c          | 50 +++++++++++-----
>>   drivers/hwtracing/coresight/coresight-etm4x.h | 58 ++++++++++++++-----
>>   include/linux/coresight.h                     |  3 +
>>   4 files changed, 89 insertions(+), 28 deletions(-)
>>
> 



More information about the linux-arm-kernel mailing list