[PATCH 02/30] pwm: atmel-tcb: Convert to platform remove callback returning void

[Claudiu.Beznea at microchip.com]

On 03.03.2023 20:54, Uwe Kleine-König wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea at microchip.com>


> ---
>  drivers/pwm/pwm-atmel-tcb.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
> index 2837b4ce8053..4a116dc44f6e 100644
> --- a/drivers/pwm/pwm-atmel-tcb.c
> +++ b/drivers/pwm/pwm-atmel-tcb.c
> @@ -500,7 +500,7 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev)
>         return err;
>  }
> 
> -static int atmel_tcb_pwm_remove(struct platform_device *pdev)
> +static void atmel_tcb_pwm_remove(struct platform_device *pdev)
>  {
>         struct atmel_tcb_pwm_chip *tcbpwm = platform_get_drvdata(pdev);
> 
> @@ -509,8 +509,6 @@ static int atmel_tcb_pwm_remove(struct platform_device *pdev)
>         clk_disable_unprepare(tcbpwm->slow_clk);
>         clk_put(tcbpwm->slow_clk);
>         clk_put(tcbpwm->clk);
> -
> -       return 0;
>  }
> 
>  static const struct of_device_id atmel_tcb_pwm_dt_ids[] = {
> @@ -564,7 +562,7 @@ static struct platform_driver atmel_tcb_pwm_driver = {
>                 .pm = &atmel_tcb_pwm_pm_ops,
>         },
>         .probe = atmel_tcb_pwm_probe,
> -       .remove = atmel_tcb_pwm_remove,
> +       .remove_new = atmel_tcb_pwm_remove,
>  };
>  module_platform_driver(atmel_tcb_pwm_driver);
> 
> --
> 2.39.1
>