[PATCH 0/2] spi: imx: Fix cleanup in remove and convert to .remove_new()

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Sun Mar 5 22:57:31 PST 2023


From: Uwe Kleine-König <uwe at kleine-koenig.org>

Hello,

this small series converts the spi-imx driver to .remove_new(). The
motivation for this tree-wide effort are drivers that don't properly
cleanup and return an error code. This is broken as this results in
resource leaks. The spi-imx driver is such a driver. The idea is that if
the remove callback returns void it's obvious that an early error return
is wrong.

Best regards
Uwe

Uwe Kleine-König (2):
  spi: imx: Don't skip cleanup in remove's error path
  spi: imx: Convert to platform remove callback returning void

 drivers/spi/spi-imx.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)


base-commit: b01fe98d34f3bed944a93bd8119fed80c856fad8
-- 
2.39.1




More information about the linux-arm-kernel mailing list