[PATCH 35/87] spi: meson-spifc: Convert to platform remove callback returning void

Martin Blumenstingl martin.blumenstingl at googlemail.com
Sat Mar 4 13:43:30 PST 2023


On Fri, Mar 3, 2023 at 6:21 PM Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Acked-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>



More information about the linux-arm-kernel mailing list