[PATCH] serial: imx: Drop a few unneeded casts

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Mar 2 08:06:37 PST 2023


Hello Ilpo,

On Thu, Mar 02, 2023 at 05:35:17PM +0200, Ilpo Järvinen wrote:
> On Thu, 2 Mar 2023, Uwe Kleine-König wrote:
> 
> > There is no point in casting a struct uart_port to a struct imx_port
> > just to access the first member of the latter (a struct uart_port).
> > 
> > This introduces code changes.
> 
> I don't know what this sentence is supposed to mean (did you forgot to 
> add a negation into it)?
> 
> The code changes :-) are okay though:

Yes, I intended to write:

	This introduces no changes to the generated binary.

> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen at linux.intel.com>

Thanks.

Greg isn't in patch collecting mood currently anyhow, so I will wait a
bit before sending out a fixed patch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230302/c4208865/attachment.sig>


More information about the linux-arm-kernel mailing list