[PATCH] serial: imx: Simplify imx_uart_type

Alexander Stein alexander.stein at ew.tq-group.com
Thu Mar 2 04:20:25 PST 2023


Hi Uwe,

Am Donnerstag, 2. März 2023, 12:55:47 CET schrieb Uwe Kleine-König:
> * PGP Signed by an unknown key
> 
> Hello,
> 
> On Thu, Mar 02, 2023 at 12:48:10PM +0100, Uwe Kleine-König wrote:
> > There is no point in casting a struct uart_port to a struct imx_port
> > just to access the first member of the latter (a struct uart_port).
> > 
> > This introduces code changes.
> 
> Please disregard this patch. While the patch is fine as is, I just
> noticed a few more functions in this driver that can be simplified
> accordingly. I'm about to send out an improved version (with a different
> subject, so not called v2).

Shouldn't this cast on the other locations be converted into a to_imx_port() 
function using container_of as well?

Best regards,
Alexander

> Best regards
> Uwe


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/





More information about the linux-arm-kernel mailing list