[PATCH] coresight: dummy: Update type of mode parameter in dummy_{sink,source}_enable()

Suzuki K Poulose suzuki.poulose at arm.com
Mon Jun 19 02:29:19 PDT 2023


On Fri, 16 Jun 2023 09:41:30 -0700, Nathan Chancellor wrote:
> Clang's kernel Control Flow Integrity (kCFI) is a compiler-based
> security mitigation that ensures the target of an indirect function call
> matches the expected type of the call and trapping if they do not match
> exactly. The warning -Wincompatible-function-pointer-types-strict aims
> to catch these issues at compile time, which reveals:
> 
>   drivers/hwtracing/coresight/coresight-dummy.c:53:12: error: incompatible function pointer types initializing 'int (*)(struct coresight_device *, struct perf_event *, enum cs_mode)' with an expression of type 'int (struct coresight_device *, struct perf_event *, u32)' (aka 'int (struct coresight_device *, struct perf_event *, unsigned int)') [-Werror,-Wincompatible-function-pointer-types-strict]
>      53 |         .enable = dummy_source_enable,
>         |                   ^~~~~~~~~~~~~~~~~~~
>   drivers/hwtracing/coresight/coresight-dummy.c:62:12: error: incompatible function pointer types initializing 'int (*)(struct coresight_device *, enum cs_mode, void *)' with an expression of type 'int (struct coresight_device *, u32, void *)' (aka 'int (struct coresight_device *, unsigned int, void *)') [-Werror,-Wincompatible-function-pointer-types-strict]
>      62 |         .enable = dummy_sink_enable,
>         |                   ^~~~~~~~~~~~~~~~~
>   2 errors generated.
> 
> [...]

Applied, thanks!

[1/1] coresight: dummy: Update type of mode parameter in dummy_{sink,source}_enable()
      commit: 185891f03f712639c082e08fc9986ff214b5d617

Best regards,
-- 
Suzuki K Poulose <suzuki.poulose at arm.com>



More information about the linux-arm-kernel mailing list