[PATCH 2/3] clk: mediatek: clk-mt8173-apmixedsys: Fix return value for of_iomap() error
Markus Schneider-Pargmann
msp at baylibre.com
Fri Jun 16 01:43:42 PDT 2023
On Thu, Jun 15, 2023 at 02:20:50PM +0200, AngeloGioacchino Del Regno wrote:
> The of_iomap() function returns NULL in case of error so usage of
> PTR_ERR() is wrong!
> Change that to return -ENOMEM in case of failure.
>
> Fixes: 41138fbf876c ("clk: mediatek: mt8173: Migrate to platform driver and common probe")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
Reviewed-by: Markus Schneider-Pargmann <msp at baylibre.com>
> ---
> drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
> index daa2856d1ab7..ba1386e70a24 100644
> --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
> +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
> @@ -148,7 +148,7 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev)
>
> base = of_iomap(node, 0);
> if (!base)
> - return PTR_ERR(base);
> + return -ENOMEM;
>
> clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
> if (IS_ERR_OR_NULL(clk_data))
> --
> 2.40.1
>
More information about the linux-arm-kernel
mailing list