[EXT] Re: [PATCH 1/8] ethosu: Add Arm Ethos-U driver

Alison Wang alison.wang at nxp.com
Fri Jun 16 01:28:59 PDT 2023


On Fri, Jun 16, 2023 at 01:59:06PM +0800, Alison Wang wrote:
> +static int ethosu_buffer_release(struct inode *inode,
> +                              struct file *file) {
> +     struct ethosu_buffer *buf = file->private_data;
> +
> +     dev_info(buf->edev->dev, "Buffer release. handle=0x%pK\n", buf);

Oh, and please remove your debugging code that you have here, and all over the place in the driver.  When drivers work properly, they are quiet, NOT printing out to the information log.

Are you sure that all of those people reviewed this thing?
[Alison Wang] These codes are also written by Arm guys. I changed dev_info to dev_dbg in the later patches.
Ok, I will remove these code.

Thanks a lot for your review.

greg k-h



More information about the linux-arm-kernel mailing list