[net PATCH v2] net: ethernet: stmicro: stmmac: fix possible memory leak in __stmmac_open

Simon Horman simon.horman at corigine.com
Wed Jun 14 12:17:30 PDT 2023


On Wed, Jun 14, 2023 at 11:17:14AM +0200, Christian Marangi wrote:
> Fix a possible memory leak in __stmmac_open when stmmac_init_phy fails.
> It's also needed to free everything allocated by stmmac_setup_dma_desc
> and not just the dma_conf struct.
> 
> Drop free_dma_desc_resources from __stmmac_open and correctly call
> free_dma_desc_resources on each user of __stmmac_open on error.
> 
> Reported-by: Jose Abreu <Jose.Abreu at synopsys.com>
> Fixes: ba39b344e924 ("net: ethernet: stmicro: stmmac: generate stmmac dma conf before open")
> Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
> Cc: stable at vger.kernel.org

Reviewed-by: Simon Horman <simon.horman at corigine.com>




More information about the linux-arm-kernel mailing list