[EXT] Re: [PATCH v2 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
Xu Yang
xu.yang_2 at nxp.com
Tue Jun 13 00:30:09 PDT 2023
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: Saturday, June 10, 2023 12:44 AM
> To: Xu Yang <xu.yang_2 at nxp.com>; robh+dt at kernel.org; krzysztof.kozlowski+dt at linaro.org; conor+dt at kernel.org
> Cc: shawnguo at kernel.org; s.hauer at pengutronix.de; kernel at pengutronix.de; festevam at gmail.com; dl-linux-imx <linux-
> imx at nxp.com>; linux-phy at lists.infradead.org; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> usb at vger.kernel.org; Jun Li <jun.li at nxp.com>
> Subject: [EXT] Re: [PATCH v2 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format
>
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> message using the 'Report this email' button
>
>
> On 08/06/2023 05:36, Xu Yang wrote:
> > Convert the binding to DT schema format. Besides, this also add other
> > optional properties not contained in txt file.
>
> Why ones do you add?
I add clock, power-domains and phy-3p0-supply to this doc. Because
the txt file should contain these properties but it not. I think the
txt doesn't get update in time.
>
> >
> > Signed-off-by: Xu Yang <xu.yang_2 at nxp.com>
> >
> > ---
> > Changes in v2:
> > - change filename to fsl,mxs-usbphy.yaml
> > - add other optional properties
> > - narrow fsl,anatop to imx6
> > - use additionalProperties
> > ---
> > .../bindings/phy/fsl,mxs-usbphy.yaml | 128 ++++++++++++++++++
> > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 -----
> > 2 files changed, 128 insertions(+), 33 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
> >
> > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > new file mode 100644
> > index 000000000000..1b6b19fdf491
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > @@ -0,0 +1,128 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> http://devicetree.org/schemas/phy/fsl,mxs-
> usbphy.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Ccdb34e27fd17419bbe3608db6908b13d%7C686ea1d3bc2b4
> c6fa92cd99c5c301635%7C0%7C0%7C638219258284008643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
> oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4pNCtSE9x4kENZsGf2nq%2F2S8uazubTjeqpSZ
> XyRRVOo%3D&reserved=0
> > +$schema: http://devicetree.org/meta-
> schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7Ccdb34e27fd17419bbe3608db6908b13d%7C686ea
> 1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638219258284008643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QjXo%2FzS6Ntl2RGBScVJfkdIONo6Sa
> psDkcDM5AY9cgQ%3D&reserved=0
> > +
> > +title: Freescale MXS USB Phy Device
> > +
> > +maintainers:
> > + - Xu Yang <xu.yang_2 at nxp.com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - fsl,imx23-usbphy
> > + - fsl,vf610-usbphy
> > + - fsl,imx7ulp-usbphy
>
> Keep the list sorted.
Okay.
>
> > + - items:
> > + - enum:
> > + - fsl,imx28-usbphy
> > + - fsl,imx6ul-usbphy
> > + - fsl,imx6sl-usbphy
> > + - fsl,imx6sx-usbphy
> > + - fsl,imx6q-usbphy
> > + - const: fsl,imx23-usbphy
> > + - items:
> > + - const: fsl,imx6sll-usbphy
> > + - const: fsl,imx6ul-usbphy
> > + - const: fsl,imx23-usbphy
> > + - items:
> > + - const: fsl,imx7ulp-usbphy
> > + - const: fsl,imx6ul-usbphy
> > + - items:
> > + - const: fsl,imx8dxl-usbphy
> > + - const: fsl,imx7ulp-usbphy
> > +
> > + reg:
> > + minItems: 1
> > + maxItems: 2
>
> You should list the items.
>
> > +
> > + interrupts:
> > + minItems: 1
> > + maxItems: 2
>
> You should list the items.
After my check, the maxItems value of reg and interrupts should be 1.
Will change it.
>
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + '#phy-cells':
> > + const: 0
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + fsl,anatop:
> > + description:
> > + phandle for anatop register, it is only for imx6 SoC series.
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > + phy-3p0-supply:
> > + description:
> > + One of USB PHY's power supply. Can be used to keep a good signal
> > + quality.
> > +
> > + fsl,tx-cal-45-dn-ohms:
> > + description:
> > + Resistance (in ohms) of switchable high-speed trimming resistor
> > + connected in parallel with the 45 ohm resistor that terminates
> > + the DN output signal.
> > + minimum: 35
> > + maximum: 54
> > + default: 45
> > +
> > + fsl,tx-cal-45-dp-ohms:
> > + description:
> > + Resistance (in ohms) of switchable high-speed trimming resistor
> > + connected in parallel with the 45 ohm resistor that terminates
> > + the DP output signal.
> > + minimum: 35
> > + maximum: 54
> > + default: 45
> > +
> > + fsl,tx-d-cal:
> > + description:
> > + Current trimming value (as a percentage) of the 17.78 mA TX
> > + reference current.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + minimum: 79
> > + maximum: 119
> > + default: 100
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - fsl,imx6sl-usbphy
>
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint.
Missed this in v2, but already checked bindings in v3. However, I have
checked schema using dt-doc-validate and dtbs using dt-validate tools.
>
> > + - fsl,imx6sx-usbphy
> > + - fsl,imx6sll-usbphy
> > + - fsl,imx6q-usbphy
> > + - fsl,vf610-usbphy
> > + - items:
> > + - const: fsl,imx6ul-usbphy
> > + - const: fsl,imx23-usbphy
> > + then:
> > + required:
> > + - fsl,anatop
> > +
> > +additionalProperties: false
> > +
>
>
> Best regards,
> Krzysztof
Thanks,
Xu Yang
More information about the linux-arm-kernel
mailing list