[PATCH v2 01/12] mmc: bcm2835: fix deferred probing
Sergey Shtylyov
s.shtylyov at omp.ru
Mon Jun 12 12:43:57 PDT 2023
On 6/9/23 12:39 AM, Stefan Wahren wrote:
[...]
>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>> permanently instead of the deferred probing. Switch to propagating the error
>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>> can safely ignore it...
>>
>> Fixes: 660fc733bd74 ("mmc: bcm2835: Add new driver for the sdhost controller.")
>
> I know this is very theoretical, but does the statement "IRQ0 is no longer returned by platform_get_irq()" also applies to the time of the fixes commit?
Unfortunately, no. IRQ0 finally ceased to be returned in 5.19; there was a fat
warning in platform_get_irq() and friends before that (which is still there)...
> I'm asking because the fix could be backported to Linux 4.14.
I think the deferred probing can currently occur only with DT platforms
(I may be wrong here). Is this your case?
> Best regards
>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov at omp.ru>
[...]
MBR, Sergey
More information about the linux-arm-kernel
mailing list