[PATCH v2] regulator: Use bitfield values for range selectors

Matti Vaittinen mazziesaccount at gmail.com
Fri Jun 9 04:02:45 PDT 2023


On 6/9/23 10:50, Chen-Yu Tsai wrote:
> Right now the regulator helpers expect raw register values for the range
> selectors. This is different from the voltage selectors, which are
> normalized as bitfield values. This leads to a bit of confusion. Also,
> raw values are harder to copy from datasheets or match up with them,
> as datasheets will typically have bitfield values.
> 
> Make the helpers expect bitfield values, and convert existing users.
> Include bitops.h explicitly for ffs(), and reorder the header include
> statements. While at it, also replace module.h with export.h, since the
> only use is EXPORT_SYMBOL_GPL.
> 
> Signed-off-by: Chen-Yu Tsai <wenst at chromium.org>
For the helpers.c and bd718x7
Reviewed-by: Matti Vaittinen <mazziesaccount at gmail.com>

Please ignore my tag in v1. I accidentally replied to wrong mail, the 
tag was meant for v2. Thanks for the heads-up Mark.

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~




More information about the linux-arm-kernel mailing list