[PATCH v2 2/2] i2c: davinci: Use struct name not type with devm_kzalloc()

Markus Elfring Markus.Elfring at web.de
Thu Jun 8 02:42:23 PDT 2023


> This reduces chance of error if the type of "dev" changes. While here
> remove extra error print out, this is not usually done for memory
> allocation failures.

https://lore.kernel.org/linux-i2c/20230515175042.495377-2-afd@ti.com/
http://patchwork.ozlabs.org/project/linux-i2c/patch/20230515175042.495377-2-afd@ti.com/

I find that this change approach does not fit to the known requirement
“Solve only one problem per patch.”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4-rc5#n81

Should desirable changes be split into better update steps?

See also:
[PATCH 0/2] I2C-DaVinci: Adjustments for davinci_i2c_probe()
https://lore.kernel.org/linux-i2c/4e668c87-65f5-8a00-132a-0184779faa08@users.sourceforge.net/
https://lkml.org/lkml/2018/2/2/541

* [1/2] i2c-davinci: Delete an error message for a failed memory allocation in davinci_i2c_probe()
  https://patchwork.ozlabs.org/project/linux-i2c/patch/f890924b-ca68-253b-a7c8-fce269393867@users.sourceforge.net/

* [2/2] i2c-davinci: Improve a size determination in davinci_i2c_probe()
  https://patchwork.ozlabs.org/project/linux-i2c/patch/e16ba754-078a-097a-7333-076f43718645@users.sourceforge.net/

Regards,
Markus



More information about the linux-arm-kernel mailing list