[PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes

Arseniy Krasnov avkrasnov at sberdevices.ru
Wed Jun 7 14:18:38 PDT 2023


Hi again Miquel, Liang!

What do You think about this patch?

Thanks, Arseniy

On 05.06.2023 22:15, Arseniy Krasnov wrote:
> Both operations have no effect.
> 
> Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru>
> ---
>  drivers/mtd/nand/raw/meson_nand.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 074e14225c06..50d3110ad321 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand,
>  	cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN;
>  	nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0;
>  
> -	addrs[0] = cs | NFC_CMD_ALE | 0;
> +	addrs[0] = cs | NFC_CMD_ALE;
>  	if (mtd->writesize <= 512) {
>  		cmd_num--;
>  		row_start = 1;
>  	} else {
> -		addrs[1] = cs | NFC_CMD_ALE | 0;
> +		addrs[1] = cs | NFC_CMD_ALE;
>  		row_start = 2;
>  	}
>  



More information about the linux-arm-kernel mailing list