[PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Wed Jun 7 07:58:30 PDT 2023


On 07/06/2023 16:52, Arseniy Krasnov wrote:
> 
> 
> On 07.06.2023 12:36, Miquel Raynal wrote:
>> Hi Arseniy,
>>
>> avkrasnov at sberdevices.ru wrote on Wed, 7 Jun 2023 12:04:29 +0300:
>>
>>> On 07.06.2023 12:08, Krzysztof Kozlowski wrote:
>>>> On 07/06/2023 10:57, Arseniy Krasnov wrote:  
>>>>>
>>>>>
>>>>> On 07.06.2023 11:53, Krzysztof Kozlowski wrote:  
>>>>>> On 07/06/2023 10:40, Arseniy Krasnov wrote:  
>>>>>>> Hello Miquel, 
>>>>>>>
>>>>>>> On 07.06.2023 10:58, Miquel Raynal wrote:
>>>>>>>  
>>>>>>>> Hi Arseniy,
>>>>>>>>
>>>>>>>> AVKrasnov at sberdevices.ru wrote on Tue, 6 Jun 2023 22:35:07 +0300:
>>>>>>>>  
>>>>>>>>> Add description of 'nand-rb' property. Use "Fixes" because this property
>>>>>>>>> must be supported since the beginning. For this controller 'nand-rb' is
>>>>>>>>> stored in the controller node (not in chip), because it has only single
>>>>>>>>> r/b wire for all chips.  
>>>>>>>>
>>>>>>>> Sorry if I mislead you in the first place, but you could definitely
>>>>>>>> have two chips and only one with RB wired. It needs to be defined in
>>>>>>>> the chips.  
>>>>>>>
>>>>>>> Ok, so to clarify: is it ok, that in bindings this property will be placed in the
>>>>>>> chip, but in driver, i'm trying to read it from the controller node (thus  in
>>>>>>> dts file it will be also in controller node)?  
>>
>> The bindings and your driver internal representation are two different
>> things. Anyway, as mentioned above, wiring the RB line to one die and
>> not the other would be valid hardware design and would require the rb
>> property to be in the chip node. Please perform a per-chip property read
>> in the driver as well.
> 
> Done, I resend both patches (bindings + driver update) as a single patchset. Your review comments
> for driver code were also fixed.

No, please send new version, not the same. New version means with fixed
comments and with patch changelog.

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list